-
Notifications
You must be signed in to change notification settings - Fork 825
Query Frontend For Logical Query Plan Support #6884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Frontend For Logical Query Plan Support #6884
Conversation
7c03859
to
0d12680
Compare
pkg/querier/tripperware/instantquery/logical_plan_gen_instant_test.go
Outdated
Show resolved
Hide resolved
5b66cc6
to
22df406
Compare
pkg/querier/tripperware/instantquery/logical_plan_gen_instant_test.go
Outdated
Show resolved
Hide resolved
24b8251
to
a278837
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for a great start
pkg/querier/tripperware/instantquery/instant_query_middlewares_test.go
Outdated
Show resolved
Hide resolved
pkg/querier/tripperware/instantquery/instant_query_middlewares_test.go
Outdated
Show resolved
Hide resolved
pkg/querier/tripperware/queryrange/query_range_middlewares_test.go
Outdated
Show resolved
Hide resolved
pkg/querier/tripperware/queryrange/query_range_middlewares_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like this initial implementation. Great work @rubywtl!
All my comments are minor.
I think we also need to update the formatting. Some of the imports are not sorted correctly.
399e190
to
d09f3d0
Compare
…ed execution feature flag Signed-off-by: rubywtl <[email protected]>
…tests Signed-off-by: rubywtl <[email protected]>
…lan-gen middleware helper functions Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
d7507ae
to
970ab81
Compare
Signed-off-by: rubywtl <[email protected]>
Signed-off-by: rubywtl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it! 💪
Great work. Thanks a lot!
What this PR does:
This PR adds logical plan generation support to the query frontend as part of the distributed query execution implementation.
Features
Configuration Changes
Testing Coverage
Integration Tests
Unit Tests
Which issue(s) this PR fixes:
Related to #6789
Checklist
CHANGELOG.md
updated