Skip to content

Query Frontend For Logical Query Plan Support #6884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 24, 2025
Merged

Query Frontend For Logical Query Plan Support #6884

merged 14 commits into from
Jul 24, 2025

Conversation

rubywtl
Copy link
Contributor

@rubywtl rubywtl commented Jul 16, 2025 •
edited
Loading

What this PR does:
This PR adds logical plan generation support to the query frontend as part of the distributed query execution implementation.

Features

  • Added middleware components for:
    • PromQL query parsing
    • Logical plan creation
    • Local optimization pipeline

    Note: Distributed optimizer will be implemented in a future stage

Configuration Changes

  • Added feature flag to query frontend configs to control distributed execution
  • Maintains backwards compatibility with existing Cortex data path

Testing Coverage

  • Integration Tests

    • Verified empty request body when feature flag is disabled
    • Validated existing data path functionality remains intact

  • Unit Tests

    • Confirmed middleware correctly serializes optimized logical query plans
    • Validated request encoding functionality

Which issue(s) this PR fixes:
Related to #6789

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated

@rubywtl rubywtl force-pushed the frontend/middleware-logicalplan-support branch 2 times, most recently from 7c03859 to 0d12680 Compare July 16, 2025 23:08
yeya24
yeya24 reviewed Jul 16, 2025
View reviewed changes
@rubywtl rubywtl force-pushed the frontend/middleware-logicalplan-support branch from 5b66cc6 to 22df406 Compare July 17, 2025 20:26
yeya24
yeya24 reviewed Jul 17, 2025
View reviewed changes
@rubywtl rubywtl force-pushed the frontend/middleware-logicalplan-support branch from 24b8251 to a278837 Compare July 17, 2025 22:19
justinjung04
justinjung04 reviewed Jul 19, 2025
View reviewed changes
Copy link
Contributor

@justinjung04 justinjung04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for a great start

harry671003
harry671003 reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@harry671003 harry671003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like this initial implementation. Great work @rubywtl!

All my comments are minor.

I think we also need to update the formatting. Some of the imports are not sorted correctly.

@rubywtl rubywtl force-pushed the frontend/middleware-logicalplan-support branch from 399e190 to d09f3d0 Compare July 22, 2025 21:04
rubywtl added 12 commits July 23, 2025 10:31
@rubywtl
frontend: Implement logical query plan middleware under new distribut…
923ddf6 
…ed execution feature flag

Signed-off-by: rubywtl <[email protected]>
@rubywtl
Combine instant and range logical query plan gen middleware + Update …
dcfccb5 
…tests

Signed-off-by: rubywtl <[email protected]>
@rubywtl
remove unneccessary configs in query frontend + restructure logical-p…
16e1f87 
…lan-gen middleware helper functions

Signed-off-by: rubywtl <[email protected]>
@rubywtl
adjust prom request logicalplan type and update tests
bd386f3 
Signed-off-by: rubywtl <[email protected]>
@rubywtl
merge related tests and improve readability
55386c3 
Signed-off-by: rubywtl <[email protected]>
@rubywtl
edit feature flag name and visibility
1f2bf91 
Signed-off-by: rubywtl <[email protected]>
@rubywtl
Add lookbackDelta and EnableStepStats back to query frontend config
5770302 
Signed-off-by: rubywtl <[email protected]>
@rubywtl
style: code cleanup and readability improvements
9ab3f81 
Signed-off-by: rubywtl <[email protected]>
@rubywtl
fix import files lint error
03c17ef 
Signed-off-by: rubywtl <[email protected]>
@rubywtl
lint: fix import orders
d8a1239 
Signed-off-by: rubywtl <[email protected]>
@rubywtl
lint: fix import order
bab8813 
Signed-off-by: rubywtl <[email protected]>
@rubywtl
remove enableStepStats from query frontend
970ab81 
Signed-off-by: rubywtl <[email protected]>
@rubywtl rubywtl force-pushed the frontend/middleware-logicalplan-support branch from d7507ae to 970ab81 Compare July 23, 2025 17:31
yeya24
yeya24 reviewed Jul 23, 2025
View reviewed changes
yeya24
yeya24 approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it! 💪
Great work. Thanks a lot!

@yeya24 yeya24 merged commit 6b3bd7b into cortexproject:master Jul 24, 2025
17 checks passed
@CharlieTLe CharlieTLe mentioned this pull request Jul 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harry671003 harry671003 harry671003 left review comments

@justinjung04 justinjung04 justinjung04 left review comments

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
component/query-frontend size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rubywtl @harry671003 @justinjung04 @yeya24